[ui] Add Integrations Marketplace to app #29027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit de33d67. |
hellendag
force-pushed
the
dish/build-904-dg-in-app
branch
2 times, most recently
from
7936528 to
4fee015
Compare
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit de33d67. |
hellendag
force-pushed
the
dish/build-904-dg-in-app
branch
from
4fee015 to
1bfe431
Compare
hellendag
commented
Apr 9, 2025
| tags: ['dagster-supported', 'etl'], | ||
| }; | ||
|
|
||
| export const content = "import DocCardList from '@theme/DocCardList';\n\n<DocCardList />"; |
There was a problem hiding this comment.
[Re: line -28]
Deleted all of these (and the generation script in ui-core) to appease TS.
See this comment inline on Graphite.
hellendag
force-pushed
the
dish/build-904-dg-in-app
branch
from
1bfe431 to
1a775f3
Compare
salazarm
reviewed
Apr 10, 2025
hellendag
force-pushed
the
dish/build-904-dg-in-app
branch
from
1a775f3 to
de33d67
Compare
[INTERNAL_BRANCH=dish/marketplace-flag]
hellendag
force-pushed
the
dish/build-904-dg-in-app
branch
from
de33d67 to
a1a78d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Behind a (still-hidden) feature flag, add the Integrations Marketplace to the app.
There is still more to add here that will be in followups:
pipanduvcommands.How I Tested These Changes
Add myself to the feature flag, view Integrations Marketplace. Verify correct rendering of list page and individual integration pages.
Outside of the flag, verify that these routes are not accessible, and that the top nav button link does not appear.